Reduce constants to NF before specialisation #3130
Merged
+48
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
force-pushed
the
3129-clash-takes-a-long-time-to-compile-a-recursively-defined-constant
branch
from
005a66e to
27fe4eb
Compare
martijnbastiaan
approved these changes
Feb 8, 2026
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
Another day another hack..
Comment on lines
+295
to
+303
| e2Red <- case collectArgs e2 of | ||
| (Prim p0, _) -> whnfRW False ctx e2 $ \_ctx1 e2Red -> case e2Red of | ||
| (collectArgs -> (Prim p1, _)) | primName p0 == primName p1 -> return e2 | ||
| _ -> changed e2Red | ||
| _ -> return e2 | ||
| specialize ctx (App e1 e2Red) |
Member
There was a problem hiding this comment.
IMO this should have a comment pointing to the bug report. I know that we can do code archaeology, but given that this is such a hack I think it deserves one.
| @@ -0,0 +1 @@ | |||
| FIXED: Reduce constants to NF before specialisation [#3129](https://github.com/clash-lang/clash-compiler/issues/3129) | |||
Member
There was a problem hiding this comment.
Suggested change
| FIXED: Reduce constants to NF before specialisation [#3129](https://github.com/clash-lang/clash-compiler/issues/3129) | |
| FIXED: Reduce constants to NF before specialization [#3129](https://github.com/clash-lang/clash-compiler/issues/3129) |
We settled on 🇺🇸 English
rowanG077
force-pushed
the
3129-clash-takes-a-long-time-to-compile-a-recursively-defined-constant
branch
from
27fe4eb to
00e3653
Compare
Member
|
I think you might have amended without mentioning files @rowanG077? |
rowanG077
force-pushed
the
3129-clash-takes-a-long-time-to-compile-a-recursively-defined-constant
branch
from
00e3653 to
9f275d9
Compare
Member
Author
|
Ugggh that's what you get when you are too long in front of the computer. It's fixed now. |
martijnbastiaan
approved these changes
Feb 8, 2026
rowanG077
deleted the
3129-clash-takes-a-long-time-to-compile-a-recursively-defined-constant
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the implementation @christiaanb gave in #3129 with an added test in the testsuite.
Fixes #3129
Still TODO: